Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dunfell] Complete Milestone 17 #1002

Merged
merged 2 commits into from Jun 6, 2022
Merged

[dunfell] Complete Milestone 17 #1002

merged 2 commits into from Jun 6, 2022

Conversation

kuta42
Copy link
Contributor

@kuta42 kuta42 commented Apr 28, 2022

No description provided.

@kuta42 kuta42 requested a review from shr-project April 28, 2022 19:53
@shr-project
Copy link
Contributor

Maybe mention that this repo is now unmaintained and OSRF looking for new maintainers?

@vmayoral
Copy link
Contributor

vmayoral commented Apr 29, 2022

@kuta42 and @shr-project, I'm working on a branch (⚠️ WIP ⚠️ ) to bring meta-ros in honister for Humble and align with REP-2008. Refer to https://discourse.ros.org/t/branched-humble-call-for-beta-testing/25284/8?u=vmayoral for my community message.

What's the process to add me as maintainer? Can you guys enable me and give me privileges? Also, regarding the current list of maintainers, is that annotated somewhere? I don't see that in the wiki.

@kuta42
Copy link
Contributor Author

kuta42 commented Apr 29, 2022

@vmayoral:

What's the process to add me as maintainer?

@tfoote controls the maintainers of meta-ros.

Also, regarding the current list of maintainers, is that annotated somewhere?

See https://github.com/orgs/ros/teams/meta-ros-maintainers

@kuta42
Copy link
Contributor Author

kuta42 commented Apr 29, 2022

Maybe mention that this repo is now unmaintained and OSRF looking for new maintainers?

kuta42 force-pushed the dunfell-next branch from adf1a38 to b06c16e 36 minutes ago

@shr-project < How does it look now?

@shr-project
Copy link
Contributor

How does it look now?

LGTM

@vmayoral
Copy link
Contributor

vmayoral commented Apr 29, 2022

@tfoote controls the maintainers of meta-ros.

thanks @kuta42, @tfoote can you help passing over maintainer’s privileges? @kuta42 and @shr-project, do any of you guys have any issues with me becoming a maintainer?

Edit: didn’t explain enough. I know the project well, been contributing since it’s early days and led teams in the past that ported the recipes to ROS 2 before LG took over it and integrated everything in here more consistently (see https://github.com/erlerobot/meta-ros2))

@kuta42 kuta42 added this to the Milestone 17 milestone Apr 30, 2022
@kuta42
Copy link
Contributor Author

kuta42 commented May 2, 2022

have any issues with me becoming a maintainer?

Not from me -- but please don't merge anything until PR-s to close Milestone 17 (#1002, 1004-1007) have been merged, which should happen by the end of this week.

@kuta42 kuta42 marked this pull request as ready for review June 6, 2022 01:03
@kuta42 kuta42 merged commit cd2e0d0 into ros:dunfell Jun 6, 2022
@kuta42
Copy link
Contributor Author

kuta42 commented Jun 6, 2022

Merged to other branches as well:
d775fdb..cd2e0d0 dunfell -> dunfell-next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants